Refactor dashboard repo list to Vue SFC #23405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
force-pushed
the
refactor-dashboard-repo-list
branch
from
4bb9816 to
d3adc0d
Compare
wxiaoguang
changed the title
silverwind
reviewed
Mar 10, 2023
GiteaBot
added
the
lgtm/need 2
silverwind
reviewed
Mar 10, 2023
silverwind
reviewed
Mar 10, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #23405 +/- ##
=======================================
Coverage ? 47.13%
=======================================
Files ? 1147
Lines ? 151255
Branches ? 0
=======================================
Hits ? 71296
Misses ? 71527
Partials ? 8432 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
techknowlogick
added
the
type/refactoring
lunny
approved these changes
Mar 12, 2023
GiteaBot
added
lgtm/need 1
This was referenced Mar 12, 2023
Closed
HesterG
approved these changes
Mar 13, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
lunny
removed
the
reviewed/wait-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #23394
The dashboard repo list mixes jQuery/Fomantic UI/Vue together, it's very diffcult to maintain and causes unfixable a11y problems.
This PR uses two steps to refactor the repo list:
data-attributes to JS object and use Vue data as much as possible d3adc0dTotal: +516 −585
Screenshots: